On Mon, Dec 23, 2024 at 05:42:36PM +0100, Mathieu Dubois-Briand wrote: > Add driver for Maxim Integrated MAX7360 GPIO/GPO controller. > > Two sets of GPIOs are provided by the device: > - Up to 8 GPIOs, shared with the PWM and rotary encoder functionalities. > These GPIOs also provide interrupts on input changes. > - Up to 6 GPOs, on unused keypad columns pins. May I ask if you researched for the existing drivers that may host this without much to modify? Second, please, avoid OF-centric APIs in a new code. Use fwnode and/or device property APIs. (This stands for the whole series and any new contributions) -- With Best Regards, Andy Shevchenko