On Tue, 21 Jan 2025 at 14:01, Oliver Neukum <oneukum@xxxxxxxx> wrote: > > This boolean statement stems from a common result, not from a common > logical reason for acting so. This is clear because if the first half > is true, you are returning itself. > > This statement would be so much more clear as: > > if (!needs_new_envelope) > return false; > > if (!old) > return needs_new_envelope; > Okay, thanks for the clarification! I'll simplify and include this suggestion in the next version. Tomasz
