Thanks a lot, Benchamin and Jiri for the suggestions.
I will send a fixup patch to solve "ERROR: modpost:
"platform_profile_cycle" [drivers/hid/hid-lenovo.ko] undefined!"
issue.
Thank You!
On Thu, Jan 9, 2025 at 11:12 PM Jiri Kosina <jikos@xxxxxxxxxx> wrote:
>
> On Thu, 9 Jan 2025, Benjamin Tissoires wrote:
>
> > > + /* Power-mode or Airplane mode will be called based on the device*/
> > > + case TP_X12_RAW_HOTKEY_FN_F8:
> > > + /*
> > > + * TP X12 TAB uses Fn-F8 calls Airplanemode
> > > + * Whereas TP X12 TAB2 uses Fn-F8 for toggling
> > > + * Power modes
> > > + */
> > > + (hdev->product == USB_DEVICE_ID_LENOVO_X12_TAB) ?
> > > + report_key_event(input, KEY_RFKILL) :
> > > + platform_profile_cycle();
> >
> > Hey,
> >
> > FWIW, this broke the CI with [0]:
> > ERROR: modpost: "platform_profile_cycle" [drivers/hid/hid-lenovo.ko] undefined!
> >
> > We are likely missing a DEPENDS or a SELECT in the Kconfig
>
> Thanks for catching it!
>
> Alternatively, we can just make the TP_X12_RAW_HOTKEY_FN_F8 case
> conditional on CONFIG_ACPI_PLATFORM_PROFILE.
>
> Vishnu, can you please send a fixup patch?
>
> Thanks,
>
> --
> Jiri Kosina
> SUSE Labs
>
--
Regards,
Vishnu Sankar
+817015150407 (Japan)
