On Wed, 25 Dec 2024, Vicki Pfau wrote: > When a force feedback command is sent from userspace, work is scheduled to pass > this data to the controller without blocking userspace itself. However, in > theory, this work might not be properly canceled if the controller is removed > at the exact right time. This patch ensures the work is properly canceled when > the device is removed. > > Signed-off-by: Vicki Pfau <vi@xxxxxxxxxxx> > --- > drivers/hid/hid-steam.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/hid/hid-steam.c b/drivers/hid/hid-steam.c > index 6439913372a8..af38fc8eb34f 100644 > --- a/drivers/hid/hid-steam.c > +++ b/drivers/hid/hid-steam.c > @@ -1306,6 +1306,7 @@ static void steam_remove(struct hid_device *hdev) > > cancel_delayed_work_sync(&steam->mode_switch); > cancel_work_sync(&steam->work_connect); > + cancel_work_sync(&steam->rumble_work); > hid_destroy_device(steam->client_hdev); > steam->client_hdev = NULL; > steam->client_opened = 0; Applied, thanks. -- Jiri Kosina SUSE Labs
