On Mon, Dec 23, 2024 at 04:59:41PM +0300, Dzmitry Sankouski wrote: > +description: | > + This is a part of device tree bindings for Maxim MAX77705. > + > + Maxim MAX77705 is a Companion Power Management and Type-C > + interface IC which includes charger, fuelgauge, LED, haptic motor driver and > + Type-C management. > + > +properties: > + compatible: > + const: maxim,max77705 > + > + "#address-cells": > + const: 1 Drop property > + > + "#size-cells": Drop > + const: 0 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + haptic: > + type: object > + additionalProperties: false > + > + properties: > + compatible: > + const: maxim,max77705-haptic > + > + haptic-supply: true > + > + pwms: > + maxItems: 1 > + > + required: > + - compatible > + - haptic-supply > + - pwms > + > + leds: > + type: object > + additionalProperties: false > + description: > + Up to 4 LED channels supported. > + > + patternProperties: > + "^led@[0-3]$": 0-2? 1-3? Preferred is the first, because we index unit addresses from 0. Please move "patternProperties" after the "properties:" block. Compatible should be the first thing visible to the reader. > + type: object > + $ref: /schemas/leds/common.yaml# > + unevaluatedProperties: false > + > + properties: > + reg: > + maxItems: 1 > + > + required: > + - reg > + > + properties: > + compatible: > + const: maxim,max77705-rgb > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > + multi-led: > + type: object > + $ref: /schemas/leds/leds-class-multicolor.yaml# > + unevaluatedProperties: false > + > + properties: > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > + patternProperties: > + "^led@[0-3]$": Same - 0-2 > + type: object > + $ref: /schemas/leds/common.yaml# > + unevaluatedProperties: false > + > + properties: > + reg: > + maxItems: 1 Best regards, Krzysztof
