[cc->to: Sudarsana, Manish, Rasesh] On Mon, Dec 09, 2024 at 02:06:25PM +0100, Philipp Stanner wrote: > pci_intx() is a hybrid function which can sometimes be managed through > devres. To remove this hybrid nature from pci_intx(), it is necessary to > port users to either an always-managed or a never-managed version. > > broadcom/bnx2x and brocade/bna enable their PCI-Device with > pci_enable_device(). Thus, they need the never-managed version. > > Replace pci_intx() with pci_intx_unmanaged(). > > Signed-off-by: Philipp Stanner <pstanner@xxxxxxxxxx> Hoping for an ack from Sudarsana, Manish, Rasesh. > --- > drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 2 +- > drivers/net/ethernet/brocade/bna/bnad.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c > index 678829646cec..2ae63d6e6792 100644 > --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c > +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c > @@ -1669,7 +1669,7 @@ static void bnx2x_igu_int_enable(struct bnx2x *bp) > REG_WR(bp, IGU_REG_PF_CONFIGURATION, val); > > if (val & IGU_PF_CONF_INT_LINE_EN) > - pci_intx(bp->pdev, true); > + pci_intx_unmanaged(bp->pdev, true); > > barrier(); > > diff --git a/drivers/net/ethernet/brocade/bna/bnad.c b/drivers/net/ethernet/brocade/bna/bnad.c > index ece6f3b48327..2b37462d406e 100644 > --- a/drivers/net/ethernet/brocade/bna/bnad.c > +++ b/drivers/net/ethernet/brocade/bna/bnad.c > @@ -2669,7 +2669,7 @@ bnad_enable_msix(struct bnad *bnad) > } > } > > - pci_intx(bnad->pcidev, 0); > + pci_intx_unmanaged(bnad->pcidev, 0); > > return; > > -- > 2.47.1 >
