Re: [PATCH] dt-bindings: input: convert dlg,da7280.txt to dt-schema

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Conor,

On 04/12/2024 18:55, Conor Dooley wrote:
On Wed, Dec 04, 2024 at 11:54:35AM +0100, Neil Armstrong wrote:

+  dlg,bemf-sens-enable:
+    type: boolean
+    description:
+      Enable for internal loop computations
+
+  dlg,freq-track-enable:
+    type: boolean
+    description:
+      Enable for resonant frequency tracking
+
+  dlg,acc-enable:
+    type: boolean
+    description:
+      Enable for active acceleration
+
+  dlg,rapid-stop-enable:
+    type: boolean
+    description:
+      Enable for rapid stop
+
+  dlg,amp-pid-enable:
+    type: boolean

Shouldn't these ones be "flag"?

Yes, I'll switch to it


+    description:
+      Enable for the amplitude PID
+
+  dlg,mem-array:
+    $ref: /schemas/types.yaml#/definitions/uint8-array
+    minItems: 100
+    description:
+      Customized waveform memory (patterns) data downloaded to the device during initialization
+
+required:
+  - compatible

Is this right? The text binding has: compatible, reg, interrupt-parent,
and a handful of vendor properties required. I don't see a mention for
the drop in the commit message.

Damn I focused on all the other parts and forgot about the required...

Thanks,
Will fix this in v2.

Neil


Cheers,
Conor.







[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux