On Wed, Dec 04, 2024 at 11:09:53PM +0300, Dzmitry Sankouski wrote: > Add maxim,max77705 binding. > > Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx> > Signed-off-by: Dzmitry Sankouski <dsankouski@xxxxxxxxx> > --- > Changes in v10: > - leds: replace label with color and function properties > - leds: add support for leds-class-multicolor > - move fuelgauge node to patternProperties "^fuel-gauge@[0-9a-f]+$" > to comply with max17042 binding You silently added significant change - new address to fuel-gauge. > > Changes in v9: > - replace max77705 fuel gauge with max17042 > - remove monitored battery because not supported by max17042 > > Changes in v8: > - fix leds compatible > > Changes in v6: > - unevaluatedProperties must be false > - drop excessive sentence from description, > just describe the device > - change leds compatible to maxim,max77705-rgb Your changelog should mention you added review here. > > Changes in v5: > - formatting changes > - add unevaluatedProperties: false for nodes referencing > common schemas > - remove additionalProperties on nodes with > unevaluatedProperties: false > - add min and max to led index > Changes in v4: > - change dts example intendation from tabs > to spaces > - remove interrupt-names property > - remove obvious reg description > - split long(>80) lines > --- > Documentation/devicetree/bindings/mfd/maxim,max77705.yaml | 192 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 193 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/maxim,max77705.yaml b/Documentation/devicetree/bindings/mfd/maxim,max77705.yaml > new file mode 100644 > index 000000000000..1bc026a01337 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/maxim,max77705.yaml > @@ -0,0 +1,192 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/maxim,max77705.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Maxim MAX77705 Companion Power Management IC and USB Type-C interface IC > + > +maintainers: > + - Dzmitry Sankouski <dsankouski@xxxxxxxxx> > + > +description: | > + The Maxim MAX77705 is a Companion Power Management and Type-C > + interface IC which includes charger, fuelgauge, LED, haptic motor driver and > + Type-C management IC. > + > +properties: > + compatible: > + const: maxim,max77705 > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 Nope, none of children are supposed to have addresses. All nodes are unit-less. > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 ... > + properties: > + compatible: > + const: maxim,max77705-rgb > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > + multi-led: > + type: object > + $ref: /schemas/leds/leds-class-multicolor.yaml# > + unevaluatedProperties: false > + > + properties: > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > + patternProperties: > + "^led@[0-3]$": > + type: object > + $ref: /schemas/leds/common.yaml# > + unevaluatedProperties: false > + > + properties: > + reg: > + maxItems: 1 > + > + required: > + - reg > + > + required: > + - compatible > + > +patternProperties: > + "^fuel-gauge@[0-9a-f]+$": How unit address appeared here? It was absolutely never reviewed. This is significant change, so drop the review tag. It's also a no, drop unit address. Best regards, Krzysztof
