Hi Terry, If only USB-audio patch is applied, the situation of mute key is not worse than the current, at least, volume adjustment issue can be fixed. So it should be OK to apply USB audio patch first. Regards Wade -----Original Message----- From: Terry Junge <linuxhid@xxxxxxxxxxxxxxxxxxxxxx> Sent: Wednesday, December 4, 2024 1:24 PM To: Takashi Iwai <tiwai@xxxxxxx> Cc: Jiri Kosina <jikos@xxxxxxxxxx>; Takashi Iwai <tiwai@xxxxxxxx>; Wang, Wade <wade.wang@xxxxxx>; Benjamin Tissoires <bentiss@xxxxxxxxxx>; Jaroslav Kysela <perex@xxxxxxxx>; linux-input@xxxxxxxxxxxxxxx; linux-sound@xxxxxxxxxxxxxxx Subject: Re: [PATCH 0/2] Introduce Poly/Plantronics mute event support CAUTION: External Email On 12/2/24 11:32 PM, Takashi Iwai wrote: > On Mon, 02 Dec 2024 23:35:51 +0100, > Terry Junge wrote: >> >> On 11/25/24 12:55 AM, Takashi Iwai wrote: >>> On Sun, 24 Nov 2024 21:32:39 +0100, >>> Terry Junge wrote: >>>> >>>> Hi Jiri and Takashi, >>>> >>>> I'm not sure how it works with two different maintained trees >>>> but this patch set needs to be applied and flow upstream together. >>>> >>>> If the HID patch is applied without the ALSA patch then mute sync >>>> issues will occur with multiple Poly/Plantronics product families. >>> >>> Both patches can be applied individually, and even if only one of them >>> is applied, it won't hurt. So I guess both subsystems can take the >>> corresponding one at any time. >>> >> >> Hi Takashi, >> >> I've tested out the behavior with each patch individually applied and >> have found that, IMHO, the mute functionality and synchronization is >> worse than the current behavior with neither patch. However, with both >> patches applied the mixer UI microphone mute control and the headset >> mute button are fully synchronized. > > That's odd. How can it worsen? As far as I understand from the patch > descriptions, the USB-audio patch corrects only the mixer volume > control names, while the HID patch changes the quirk to be generalized > (to be dropped the next key in a short period). If only USB audio > patch is applied, it doesn't matter as the volume binding didn't > happen before the patch. OTOH, ditto, if only HID patch is applied. > Am I missing anything here? The USB-audio patch also corrects the names for the mixer switch controls. The HID patch also adds mapping of the mute button to the KEY_MICMUTE event. It's not the playback volume handling that gets worse, it's the capture switch handling that gets worse. The USB-audio patch allows the mixer to bind to the headset's mute control in the feature unit and mute/un-mute the headset microphone while the HID patch allows the headset to request the mixer to toggle the microphone mute state. Both patches are needed for microphone mute synchronization to work. thanks, Terry > >> There must be a way that both patches can be tied together and be >> applied simultaneously. >> >> If it would help, and be allowed, I can submit a single patch that >> contains both changes. > > Applying both from the single tree is possible, sure. One of two > needs an ack from the subsystem maintainers. > > > thanks, > > Takashi > >> >> Thanks, >> Terry >> >>> >>> thanks, >>> >>> Takashi >>> >>>> >>>> This patch set was tested by Wade and myself with multiple >>>> Poly/Plantronics product family headsets. >>>> >>>> Hi Wade, >>>> >>>> Please feel free to add your Signed-off-by: and/or Tested-by: tags, >>>> as you see fit. >>>> >>>> Thanks, >>>> Terry >>>> >>>> Terry Junge (2): >>>> HID: hid-plantronics: Add mic mute mapping and generalize quirks >>>> ALSA: usb-audio: Add quirk for Plantronics headsets to fix control >>>> names >>>> >>>> drivers/hid/hid-plantronics.c | 135 ++++++++++++++++------------------ >>>> sound/usb/mixer_quirks.c | 35 +++++++++ >>>> 2 files changed, 100 insertions(+), 70 deletions(-) >>>> >>>> >>>> base-commit: 28eb75e178d389d325f1666e422bc13bbbb9804c >>>> -- >>>> 2.43.0 >>>> >>
