Hi mjchen, kernel test robot noticed the following build errors: [auto build test ERROR on dtor-input/next] [also build test ERROR on dtor-input/for-linus robh/for-next soc/for-next linus/master v6.12-rc7 next-20241112] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/mjchen/dt-bindings-input-Add-Nuvoton-MA35D1-keypad/20241112-133327 base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next patch link: https://lore.kernel.org/r/20241112053059.3361-3-mjchen0829%40gmail.com patch subject: [PATCH v2 2/2] input: keypad: add new keypad driver for MA35D1 config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20241112/202411121749.9xapQvza-lkp@xxxxxxxxx/config) compiler: m68k-linux-gcc (GCC) 14.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241112/202411121749.9xapQvza-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202411121749.9xapQvza-lkp@xxxxxxxxx/ All error/warnings (new ones prefixed by >>): drivers/input/keyboard/ma35d1_keypad.c: In function 'ma35d1_keypad_scan_matrix': >> drivers/input/keyboard/ma35d1_keypad.c:83:53: warning: left shift count >= width of type [-Wshift-count-overflow] 83 | pressed_keys = key_event[0] | key_event[1] << 32; | ^~ drivers/input/keyboard/ma35d1_keypad.c:84:53: warning: left shift count >= width of type [-Wshift-count-overflow] 84 | released_keys = key_event[2] | key_event[3] << 32; | ^~ drivers/input/keyboard/ma35d1_keypad.c: In function 'ma35d1_keypad_open': >> drivers/input/keyboard/ma35d1_keypad.c:130:16: error: implicit declaration of function 'FIELD_PREP' [-Wimplicit-function-declaration] 130 | val |= FIELD_PREP(KCOL, (keypad->kpi_col - 1)) | FIELD_PREP(KROW, (keypad->kpi_row - 1)); | ^~~~~~~~~~ vim +/FIELD_PREP +130 drivers/input/keyboard/ma35d1_keypad.c 59 60 static void ma35d1_keypad_scan_matrix(struct ma35d1_keypad *keypad, unsigned int status) 61 { 62 struct input_dev *input_dev = keypad->input_dev; 63 unsigned int code; 64 unsigned int key; 65 unsigned long pressed_keys = 0, released_keys = 0; 66 unsigned int row_shift = get_count_order(keypad->kpi_col); 67 unsigned short *keymap = input_dev->keycode; 68 unsigned long key_event[4]; 69 unsigned int index; 70 71 /* Read key event status */ 72 key_event[0] = readl(keypad->mmio_base + KPI_KPE0); 73 key_event[1] = readl(keypad->mmio_base + KPI_KPE1); 74 key_event[2] = readl(keypad->mmio_base + KPI_KRE0); 75 key_event[3] = readl(keypad->mmio_base + KPI_KRE1); 76 77 /* Clear key event status */ 78 writel(key_event[0], (keypad->mmio_base + KPI_KPE0)); 79 writel(key_event[1], (keypad->mmio_base + KPI_KPE1)); 80 writel(key_event[2], (keypad->mmio_base + KPI_KRE0)); 81 writel(key_event[3], (keypad->mmio_base + KPI_KRE1)); 82 > 83 pressed_keys = key_event[0] | key_event[1] << 32; 84 released_keys = key_event[2] | key_event[3] << 32; 85 86 /* Process pressed keys */ 87 for_each_set_bit(index, &pressed_keys, KEY_EVENT_BITS) { 88 code = MATRIX_SCAN_CODE(index / 8, (index % 8), row_shift); 89 key = keymap[code]; 90 91 input_event(input_dev, EV_MSC, MSC_SCAN, code); 92 input_report_key(input_dev, key, 1); 93 } 94 95 /* Process released keys */ 96 for_each_set_bit(index, &released_keys, KEY_EVENT_BITS) { 97 code = MATRIX_SCAN_CODE(index / 8, (index % 8), row_shift); 98 key = keymap[code]; 99 100 input_event(input_dev, EV_MSC, MSC_SCAN, code); 101 input_report_key(input_dev, key, 0); 102 } 103 104 input_sync(input_dev); 105 } 106 107 static irqreturn_t ma35d1_keypad_interrupt(int irq, void *dev_id) 108 { 109 struct ma35d1_keypad *keypad = dev_id; 110 unsigned int kstatus; 111 112 kstatus = readl(keypad->mmio_base + KPI_STATUS); 113 114 if (kstatus & (PKEY_INT | RKEY_INT)) { 115 ma35d1_keypad_scan_matrix(keypad, kstatus); 116 } else { 117 if (kstatus & PDWAKE) 118 writel(PDWAKE, (keypad->mmio_base + KPI_STATUS)); 119 } 120 121 return IRQ_HANDLED; 122 } 123 124 static int ma35d1_keypad_open(struct input_dev *dev) 125 { 126 struct ma35d1_keypad *keypad = input_get_drvdata(dev); 127 unsigned int val, config; 128 129 val = RKINTEN | PKINTEN | INTEN | ENKP; > 130 val |= FIELD_PREP(KCOL, (keypad->kpi_col - 1)) | FIELD_PREP(KROW, (keypad->kpi_row - 1)); 131 132 if (keypad->debounce_val > 0) 133 config = FIELD_PREP(PRESCALE, (keypad->pre_scale - 1)) | 134 FIELD_PREP(DB_CLKSEL, keypad->debounce_val); 135 else 136 config = FIELD_PREP(PRESCALE, (keypad->pre_scale - 1)); 137 138 val |= config; 139 140 writel(val, keypad->mmio_base + KPI_CONF); 141 writel((keypad->pre_scale_divider - 1), keypad->mmio_base + KPI_PRESCALDIV); 142 143 return 0; 144 } 145 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
