Hi Doug, On Fri, Nov 08, 2024 at 07:13:53AM -0800, Doug Anderson wrote: > Hi, > > On Fri, Nov 8, 2024 at 5:33 AM Rob Herring (Arm) <robh@xxxxxxxxxx> wrote: > > > > > > On Fri, 08 Nov 2024 20:03:10 +0800, Charles Wang wrote: > > > The Goodix GT7986U touch controller report touch data according to the > > > HID protocol through the SPI bus. However, it is incompatible with > > > Microsoft's HID-over-SPI protocol. > > > > > > NOTE: these bindings are distinct from the bindings used with the > > > GT7986U when the chip is running I2C firmware. For some background, > > > see discussion on the mailing lists in the thread: > > > > > > https://lore.kernel.org/r/20241018020815.3098263-2-charles.goodix@xxxxxxxxx > > > > > > Signed-off-by: Charles Wang <charles.goodix@xxxxxxxxx> > > > --- > > > .../bindings/input/goodix,gt7986u-spifw.yaml | 75 +++++++++++++++++++ > > > 1 file changed, 75 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/input/goodix,gt7986u-spifw.yaml > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > yamllint warnings/errors: > > ./Documentation/devicetree/bindings/input/goodix,gt7986u-spifw.yaml:16:7: [error] syntax error: mapping values are not allowed here (syntax) > > FWIW, I think it's objecting to the "NOTE: " in the description > looking like yaml. Maybe just change it to "Note that". It's also a > good idea to get yourself setup to validate your bindings _before_ > posting them to the list. > Change to 'description: |' fixed the issue. Thanks, Charles
