Re: [PATCH v1 4/6] pcmcia: soc_common: Avoid using GPIOF_ACTIVE_LOW

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Fri, Nov 08, 2024 at 10:35:41AM +0200 schrieb Andy Shevchenko:
> On Fri, Nov 08, 2024 at 09:28:19AM +0100, Linus Walleij wrote:
> > On Mon, Nov 4, 2024 at 10:36 AM Andy Shevchenko
> > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > 
> > > Avoid using GPIOF_ACTIVE_LOW as it's deprecated and subject to remove.
> > >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > 
> > Looks right to me, some testing would be even better
> > because I never trust these flags to get right.
> 
> I also would like to have this, but seems the only odd fixer was active ca.
> 2023 last time, I'm not sure we may hear from Dominik in time, otherwise the
> series will be postponed for unknown period of time, which I do not prefer,
> rather I will fix any regressions later (but I doubt there are here).

As I don't have such hardware, I cannot help with testing, but from the
PCMCIA point of view:

	Acked-by: Dominik Brodowski <linux@xxxxxxxxxxxxxxxxxxxx>

Thanks,
	Dominik




[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux