Hi, On Fri, Nov 8, 2024 at 4:03 AM Charles Wang <charles.goodix@xxxxxxxxx> wrote: > > The Goodix GT7986U touch controller report touch data according to the > HID protocol through the SPI bus. However, it is incompatible with > Microsoft's HID-over-SPI protocol. > > The patchset introduces the following two changes: > 1) Add goodix,gt7986u-spifw.yaml. > 2) Drop the 'goodix,hid-report-addr' property. > > Signed-off-by: Charles Wang <charles.goodix@xxxxxxxxx> > --- > Changes in v3: > - Split the commit into two patches. LOL, this isn't what I meant. You should have one patch adding the proper bindings, but you need a second patch to _the "driver_. Right now the driver (AKA the file "drivers/hid/hid-goodix-spi.c" in Linux) is still looking for "goodix,hid-report-addr". The driver needs to be updated and that was what I was saying should be patch #2. You'll also need to fix the driver to update the compatible string it's looking for. -Doug
