On Wed, 06 Nov 2024 09:07:07 -0800 srinivas pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx> wrote: > On Fri, 2024-11-01 at 15:32 +0000, Jonathan Cameron wrote: > > On Fri, 01 Nov 2024 07:46:26 +0000 > > Ricardo Ribalda <ribalda@xxxxxxxxxxxx> wrote: > > > > > EgisVision 620 provides two additional channels: > > > - proximity > > > - attention > > > > > > Add support for them. > > > > > > Signed-off-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx> > > Looks good to me. I'll queue it up, but Jiri / Srinivas if either of > > you have time > > to take a look as well that would be great of course. > > > Sorry for the delay. I was on vacation. > > Acked-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx> No problem. It ended up behind a merge commit that I don't really want to redo, but there is a link to this thread for the extra tags. Thanks, Jonathan > > > I'll only push this out as testing for now to let 0-day take a look. > > > > > > > --- > > > Changes in v3: > > > - Make attention CHAN_INFO_PROCESSED. > > > - Fix comment style. > > > - Multiply attention by 100 to make it a percentage. > > > - Link to v2: > > > https://lore.kernel.org/r/20241028-hpd-v2-0-18f6e79154d7@xxxxxxxxxxxx > > > > > > Changes in v2 (Thanks Jonathan): > > > - Create new attention channel type. > > > - Improve documentation for HID usages. > > > - Link to v1: > > > https://lore.kernel.org/r/20241024-hpd-v1-0-2a125882f1f8@xxxxxxxxxxxx > > > > > > --- > > > Ricardo Ribalda (5): > > > iio: hid-sensors: Add proximity and attention IDs > > > iio: hid-sensors-prox: Factor-in hid_sensor_push_data > > > iio: Add channel type for attention > > > iio: hid-sensors-prox: Make proximity channel indexed > > > iio: hid-sensor-prox: Add support for more channels > > > > > > Documentation/ABI/testing/sysfs-bus-iio | 8 ++ > > > drivers/iio/industrialio-core.c | 1 + > > > drivers/iio/light/hid-sensor-prox.c | 195 ++++++++++++++++++-- > > > ------------ > > > include/linux/hid-sensor-ids.h | 2 + > > > include/uapi/linux/iio/types.h | 1 + > > > tools/iio/iio_event_monitor.c | 2 + > > > 6 files changed, 122 insertions(+), 87 deletions(-) > > > --- > > > base-commit: c2ee9f594da826bea183ed14f2cc029c719bf4da > > > change-id: 20241023-hpd-edeb37f1ffc4 > > > > > > Best regards, > > >
