On Mon, 28 Oct 2024 12:07:50 -0700, Dmitry Torokhov wrote: > mt_set_mode() accepts 2 boolean switches indicating whether the device > (if it follows Windows Precision Touchpad specification) should report > hardware buttons and/or surface contacts. For a casual reader it is > completely not clear, as they look at the call site, which exact mode > is being requested. > > Define report_mode enum and change mt_set_mode() to accept is as > an argument instead. This allows to write: > > [...] Applied to hid/hid.git (for-6.13/multitouch), thanks! [1/1] HID: multitouch: make mt_set_mode() less cryptic https://git.kernel.org/hid/hid/c/5f21e2242f9f Cheers, -- Benjamin Tissoires <bentiss@xxxxxxxxxx>