Re: [PATCH v6 7/7] leds: max77705: Add LEDs support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



(...)
> >  drivers/leds/leds-max77705.c | 157 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>
> Lol!  How big is your terminal? :)
>

Dunno actually, this was generated by b4

(...)


> No C++ comments please.
>

This conflicts with https://patchwork.kernel.org/comment/25898728/

> > +             ret = regmap_update_bits(led->regmap,
> > +                                     MAX77705_RGBLED_REG_LEDEN,
> > +                                     MAX77705_LED_EN_MASK << led->en_shift, 0);
> > +             max77705_rgb_blink(cdev, &blink_default, &blink_default);
> > +     } else {
> > +             // Set current
> > +             ret = regmap_write(led->regmap,
> > +                                led->reg_brightness, brightness);
>
> Line wrap at 100-chars.
>


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux