Hi Christopher, On Fri, Oct 11, 2024 at 05:59:42AM -0700, Christopher Snowhill wrote: > On Thu Oct 10, 2024 at 4:09 PM PDT, John Edwards wrote: > > Add MSI Claw A1M controller to xpad_device match table when in xinput mode. > > Add MSI VID as XPAD_XBOX360_VENDOR. > > > > Signed-off-by: John Edwards <uejji@xxxxxxxxx> > > Reviewed-by: Derek J. Clark <derekjohn.clark@xxxxxxxxx> > > Um, I may have erred with my contribution of a R-b? Do I have to test > the patch on the device in question to review it? If so, I'll just Ack > the patch as looking properly drafted, and applying cleanly. Sorry for > the noise. No, you do not need to test the patch to review it. We have a separate "Tested-by" tag to signal when a person did test the patch with their setup. Thanks. -- Dmitry