Hi Kamal, On Fri, Oct 18, 2024 at 06:22:35PM +0530, Kamal Wadhwa wrote: > GPIO IRQ setting may get reset during hibernate mode, as device > is completely powered off. This can cause the GPIO keys to become > un-responsive after hibernate-exit. > > To fix this problem, re-request IRQs in restore() callback, in the > hibernate exit flow. No, absolutely not. GPIO state and configuration is owned by GPIO controller and it should be the entity tasked with restoring the configuration after hibernation. Individual GPIO consumers need not do that. Same goes for coprocessor and what's not. Also, as a side statement: whenever you call devm API outside of probe and remove path you are likely introduce bugs, because that interferes with the original order of acquisition of the resources so order of releasing them during unbinding of the device from the driver will likely be wrong. Thanks. -- Dmitry
