On Wed, 16 Oct 2024, Andy Shevchenko wrote: > Duplicates in 'keys prevents kernel builds with clang, `make W=1` and > CONFIG_WERROR=y, for example: > > drivers/hid/hid-debug.c:3443:18: error: initializer overrides prior initialization of this subobject [-Werror,-Winitializer-overrides] > 3443 | [KEY_HANGEUL] = "HanGeul", [KEY_HANGUP_PHONE] = "HangUpPhone", > | ^~~~~~~~~ > drivers/hid/hid-debug.c:3217:18: note: previous initialization is here > 3217 | [KEY_HANGUEL] = "Hangeul", [KEY_HANJA] = "Hanja", > | ^~~~~~~~~ > > Fix this by removing them. > > The logic of removal is that, remove... > 1) if there is a constant that uses another defined constant, OR > 2) the one that appears later in the list. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > --- > v2: fixed which one to remove for KEY_HANGEUL (Jiri) > drivers/hid/hid-debug.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) Applied, thanks. -- Jiri Kosina SUSE Labs
