On Tue, Oct 15, 2024 at 02:20:19PM +0200, Jiri Kosina wrote:
> On Thu, 5 Sep 2024, Andy Shevchenko wrote:
...
> > drivers/hid/hid-debug.c:3443:18: error: initializer overrides prior initialization of this subobject [-Werror,-Winitializer-overrides]
> > 3443 | [KEY_HANGEUL] = "HanGeul", [KEY_HANGUP_PHONE] = "HangUpPhone",
> > | ^~~~~~~~~
> > drivers/hid/hid-debug.c:3217:18: note: previous initialization is here
> > 3217 | [KEY_HANGUEL] = "Hangeul", [KEY_HANJA] = "Hanja",
> > | ^~~~~~~~~
> >
> > Fix this by removing them.
> >
> > The logic of removal is that, remove...
> > 1) if there is a constant that uses another defined constant, OR
> > 2) the one that appears later in the list.
...
> > - [KEY_HANGUEL] = "Hangeul", [KEY_HANJA] = "Hanja",
>
> The problem specifically with this one is really there to fix a typo
> someone did at some point in the past. See b9ab58dd8e771d ("Input: fix
> misspelling of Hangeul key").
>
> So I think we should preserve it somehow.
Right, I fixed that in v2 that has been just sent out.
--
With Best Regards,
Andy Shevchenko
