Hi,
Am 08.10.24 um 17:33 schrieb Lee Jones:
On Mon, 07 Oct 2024, Werner Sembach wrote:
Am 07.10.24 um 14:58 schrieb Lee Jones:
On Fri, 04 Oct 2024, Werner Sembach wrote:
Am 03.10.24 um 09:59 schrieb Lee Jones:
On Wed, 02 Oct 2024, Werner Sembach wrote:
Hi,
Am 02.10.24 um 14:52 schrieb Lee Jones:
On Fri, 27 Sep 2024, Werner Sembach wrote:
Hi,
first revision integrating Armins feedback.
Stuff I did not yet change and did not comment on previously:
- Still have to ask Christoffer why the mutex is required
- Still using acpi_size instad of size_t in the util functions, because the value is put directly into a struct using acpi_size
- Error messages for __wmi_method_acpi_object_out still in that method because they reference method internal variables
Let me know if my reasoning is flawed
Use `git format-patch`'s --annotate and --compose next time please.
I did but --compose does not automatically insert the subject line, that's
why i copied it but forgot to change it to 0/1
Sorry for the flawed subject line
And the missing diff-stat?
Also not automatically created by git send-email --compose. is there a flag
I'm not aware of?
As above. I use "--annotate --compose". See if that works.
nope, the cover letter has no change summary with these options
Oh, my mistake. I'm getting confused with `git send-email`.
You want this:
`mkdir patches && git format-patch --cover-letter -M -o patches`
ah ok thanks, will note it down for the next patch.
Regards,
Werner
