Re: [PATCH v3 RESEND] HID: logitech-dj: Add support for a new lightspeed receiver iteration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Oct 08 2024, Jiri Kosina wrote:
> On Thu, 27 Jun 2024, Mavroudis Chatzilazaridis wrote:
> 
> > The lightspeed receiver for the Pro X Superlight uses 13 byte mouse reports
> > without a report id. The workaround for such cases has been adjusted to
> > handle these larger packets.
> > 
> > The device now reports the status of its battery in wireless mode and
> > libratbag now recognizes the device and it can be configured with Piper.
> > 
> > This receiver has new descriptors, which have been added. The mouse
> > descriptor has 5 extra vendor defined bytes at the end, while the keyboard
> > one has a different report layout and minimums/maximums. As such, mice
> > with key press macros and keyboards that use this receiver misbehave
> > without them.
> > 
> > Fixes: 9d1bd9346241 (HID: logitech-dj: Add support for a new lightspeed receiver iteration)
> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=218172
> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=218094
> > Link: https://lore.kernel.org/r/CAOEevLOrTSugnLePJwpcqx2_AacNbBxFZDTqp0Qm_jjVpWKgFQ@xxxxxxxxxxxxxx/
> > Link: https://lore.kernel.org/r/6929ebbf-f2e0-4cd4-addc-1e33ecf3277f@xxxxxxxxx/
> > Co-developed-by: Filipe Laíns <lains@xxxxxxxxxx>
> > Signed-off-by: Filipe Laíns <lains@xxxxxxxxxx>
> > Signed-off-by: Mavroudis Chatzilazaridis <mavchatz@xxxxxxxxxxxxxx>
> 
> Given the regressions this caused in the previous attempt ... Benjamin, 
> would it be possible to get some sort of extensive targetted testing in 
> your CI, please?
> 

I wish it were that simple. I currently have a unifying receiver
connected to the CI and checks that the driver brings it up. However, I
do not have a full receiver emulation, meaning that I can not do full
extensive testing :(
That's one of the reasons why I hate so much that driver now, because
everything can fall apart so easily :(

Cheers,
Benjamin




[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux