On Mon, 9 Sep 2024, Stuart Hayhurst wrote: > Introduce a driver for the Corsair Void family of headsets, supporting: > - Battery reporting (power_supply) > - Sidetone setting support > - Physical microphone location reporting > - Headset and receiver firmware version reporting > - Built-in alert triggering > - USB wireless_status > > Tested with a Void Pro Wireless, Void Elite Wireless and a Void Elite Wired > > Signed-off-by: Stuart Hayhurst <stuart.a.hayhurst@xxxxxxxxx> Thanks a lot for working on this! I have one small nit: [ ... snip ... ] > +config HID_CORSAIR_VOID > + tristate "Corsair Void headsets" > + depends on USB_HID > + select POWER_SUPPLY > + help > + Support for Corsair Void headsets. > + > + Supported devices: > + - Corsair Void headsets > + As we alreay have general CONFIG_HID_CORSAIR, I think it'd make sense for this driver to be encapsulated under this config option as well (it'd also follow the general practice of HID subsystem, that the drivers are divided per vendor) -- i.e. link hid-corsair-void into the final hid-corsair.ko whenever CONFIG_HID_CORSAIR is selected. Would you be willing to make that small change, and resubmit for final merge? Thanks, -- Jiri Kosina SUSE Labs
