Hi Dmitry, Here it goes v2. I ended up squashing the patches as the patch is still fairly simple. --- Changes in v2: - Link to v1: https://lore.kernel.org/r/20241002-fix-adp5588-read-refactor-v1-0-28800f1b9773@xxxxxxxxxx - Squashed patch 1 and 2 so that we don't return an int into an u8. --- Nuno Sa (3): Input: adp5588-keys: bail on returned error Input: adp5588-keys: error out if no IRQ is given Input: adp5588-keys: make use of dev_err_probe() drivers/input/keyboard/adp5588-keys.c | 151 +++++++++++++++++++--------------- 1 file changed, 86 insertions(+), 65 deletions(-) --- base-commit: c684771630e64bc39bddffeb65dd8a6612a6b249 change-id: 20241002-fix-adp5588-read-refactor-a85c88af4062 -- Thanks! - Nuno Sá