Hi Dmitry, As suggested by you in [1], here it goes a small series to make sure we check for error codes in adp5588_read() plus a following patch refactoring the function. In addition a couple more commits doing a simple conversion to dev_err_probe() and a sanity check for IRQ presence (when the keymap is to be used). [1]: https://lore.kernel.org/linux-input/Zu0vq0ogr2HzXWv7@xxxxxxxxxx/ --- Nuno Sa (4): Input: adp5588-keys: bail on returned error Input: adp5588-keys: refactor adp5589_read() Input: adp5588-keys: error out if no IRQ is given Input: adp5588-keys: make use of dev_err_probe() drivers/input/keyboard/adp5588-keys.c | 151 +++++++++++++++++++--------------- 1 file changed, 86 insertions(+), 65 deletions(-) --- base-commit: c684771630e64bc39bddffeb65dd8a6612a6b249 change-id: 20241002-fix-adp5588-read-refactor-a85c88af4062 -- Thanks! - Nuno Sá
