On 26/09/2024 11:57, Charles Wang wrote: >>> 1 file changed, 71 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/input/goodix,gt7986u.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/input/goodix,gt7986u.yaml b/Documentation/devicetree/bindings/input/goodix,gt7986u.yaml >>> new file mode 100644 >>> index 000000000..849117639 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/input/goodix,gt7986u.yaml >>> @@ -0,0 +1,71 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/input/goodix,gt7986u.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: GOODIX GT7986U SPI HID Touchscreen >>> + >>> +maintainers: >>> + - Charles Wang <charles.goodix@xxxxxxxxx> >>> + >>> +description: Supports the Goodix GT7986U touchscreen. >>> + This touch controller reports data packaged according to the HID protocol, >>> + but is incompatible with Microsoft's HID-over-SPI protocol. >>> + >>> +allOf: >>> + - $ref: /schemas/spi/spi-peripheral-props.yaml# >>> + >>> +properties: >>> + compatible: >>> + enum: >>> + - goodix,gt7986u-spi >> >> NAK, you duplicate again the binding. You cannot have bus-flavors. >> Device is the same. >> > > Could you provide some suggestions regarding this issue? What is exactly the question or problem? There is a binding for this device. Extend it with SPI parts, e.g. https://elixir.bootlin.com/linux/v6.4-rc7/source/Documentation/devicetree/bindings/iio/accel/adi,adxl313.yaml#L22 Best regards, Krzysztof
