Hi Oleh, On Tue, Sep 10, 2024 at 01:51:57PM +0200, Oleh Kuzhylnyi wrote: > Add documentation for the Hynitron CST816X touchscreen bindings. > > Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > Signed-off-by: Oleh Kuzhylnyi <kuzhylol@xxxxxxxxx> > --- > > Changes in v6: > - Fix minor tweak adviced by Krzysztof: > - Move additionalProperties field after required > > Changes in v5: > - No code changes > > Changes in v4: > - Add Conor's Dooley "Reviewed-by" tag > > Changes in v3: > - Rename filename to hynitron,cst816s.yaml > - Update description with display details > > Changes in v2: > - Apply pin definitions and DT headers > - Use generic name for DT node > - Drop status field > > .../input/touchscreen/hynitron,cst816s.yaml | 57 +++++++++++++++++++ > 1 file changed, 57 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/touchscreen/hynitron,cst816s.yaml > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/hynitron,cst816s.yaml b/Documentation/devicetree/bindings/input/touchscreen/hynitron,cst816s.yaml > new file mode 100644 > index 000000000000..b3f4049e4b9b > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/touchscreen/hynitron,cst816s.yaml > @@ -0,0 +1,57 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/input/touchscreen/hynitron,cst816s.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Hynitron CST816S Touchscreen controller > + > +description: > + Hynitron CST816S Touchscreen controller for 1.28-inch 240x240 Resolution > + Touch LCD Display Module > + > +maintainers: > + - Oleh Kuzhylnyi <kuzhylol@xxxxxxxxx> > + > +allOf: > + - $ref: touchscreen.yaml# > + > +properties: > + compatible: > + enum: > + - hynitron,cst816s > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + reset-gpios: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - reset-gpios The reset GPIO is not required; it may simply be pulled up locally. > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + #include <dt-bindings/interrupt-controller/irq.h> > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + touchscreen@15 { > + compatible = "hynitron,cst816s"; > + reg = <0x15>; > + interrupt-parent = <&gpio0>; > + interrupts = <4 IRQ_TYPE_EDGE_RISING>; > + reset-gpios = <&gpio 17 GPIO_ACTIVE_LOW>; > + }; > + }; > + > +... > -- > 2.34.1 > Kind regards, Jeff LaBundy