Re: [PATCH 1/2] HID: wacom: Support sequence numbers smaller than 16-bit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 9 Sep 2024, Gerecke, Jason wrote:

> From: Jason Gerecke <jason.gerecke@xxxxxxxxx>
> 
> The current dropped packet reporting assumes that all sequence numbers
> are 16 bits in length. This results in misleading "Dropped" messages if
> the hardware uses fewer bits. For example, if a tablet uses only 8 bits
> to store its sequence number, once it rolls over from 255 -> 0, the
> driver will still be expecting a packet "256". This patch adjusts the
> logic to reset the next expected packet to logical_minimum whenever
> it overflows beyond logical_maximum.
> 
> Signed-off-by: Jason Gerecke <jason.gerecke@xxxxxxxxx>
> Tested-by: Joshua Dickens <joshua.dickens@xxxxxxxxx>
> Fixes: 6d09085b38e5 ("HID: wacom: Adding Support for new usages")

Hi Jason,

thanks for both fixes.

Looking at them, it seems like it'd normally be 6.11 material, but given

- how far we currently are in a 6.11 development cycle
- how long this issue has been present in the code
- the fact that it actually does change the event processing behavior

I have to ask you for a judgement -- would you like to absolutely see 
these in 6.11 as last-minute fixes, or do you consider this to be 6.12 
material?

Thanks,

-- 
Jiri Kosina
SUSE Labs





[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux