On Mon, Sep 02, 2024 at 10:08:05AM +0200, Andreas Kemnade wrote: > Hi Dmitry, > > Am Fri, 23 Aug 2024 22:50:24 -0700 > schrieb Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>: > > > Hi, > > > > This is a set of somewhat random cleanups for the zforce_ts driver. > > > > Heiko, Andreas, if you still have access to the hardware it would be > > great if you could give it a spin. > > > > Thanks! > > > nice cleanup, > I tested a bit on the Toline Shine 2HD without gui (have not rebased my > other stuff to 6.11 yet) > > A short move on the touchscreen gives this: > Event: time 1725264307.093542, type 3 (EV_ABS), code 57 (ABS_MT_TRACKING_ID), value 24 > Event: time 1725264307.093542, type 3 (EV_ABS), code 53 (ABS_MT_POSITION_X), value 1159 > Event: time 1725264307.093542, type 3 (EV_ABS), code 54 (ABS_MT_POSITION_Y), value 596 > Event: time 1725264307.093542, type 3 (EV_ABS), code 48 (ABS_MT_TOUCH_MAJOR), value 11 > Event: time 1725264307.093542, type 3 (EV_ABS), code 49 (ABS_MT_TOUCH_MINOR), value 11 > Event: time 1725264307.093542, type 3 (EV_ABS), code 52 (ABS_MT_ORIENTATION), value 0 > Event: time 1725264307.093542, type 1 (EV_KEY), code 330 (BTN_TOUCH), value 1 > Event: time 1725264307.093542, type 3 (EV_ABS), code 0 (ABS_X), value 1159 > Event: time 1725264307.093542, type 3 (EV_ABS), code 1 (ABS_Y), value 596 > Event: time 1725264307.093542, -------------- SYN_REPORT ------------ > Event: time 1725264307.096361, type 3 (EV_ABS), code 53 (ABS_MT_POSITION_X), value 1039 > Event: time 1725264307.096361, type 3 (EV_ABS), code 54 (ABS_MT_POSITION_Y), value 607 > Event: time 1725264307.096361, type 3 (EV_ABS), code 0 (ABS_X), value 1039 > Event: time 1725264307.096361, type 3 (EV_ABS), code 1 (ABS_Y), value 607 > Event: time 1725264307.096361, -------------- SYN_REPORT ------------ > Event: time 1725264307.112426, type 3 (EV_ABS), code 53 (ABS_MT_POSITION_X), value 934 > Event: time 1725264307.112426, type 3 (EV_ABS), code 54 (ABS_MT_POSITION_Y), value 637 > Event: time 1725264307.112426, type 3 (EV_ABS), code 0 (ABS_X), value 934 > Event: time 1725264307.112426, type 3 (EV_ABS), code 1 (ABS_Y), value 637 > Event: time 1725264307.112426, -------------- SYN_REPORT ------------ > Event: time 1725264307.131523, type 3 (EV_ABS), code 53 (ABS_MT_POSITION_X), value 859 > Event: time 1725264307.131523, type 3 (EV_ABS), code 54 (ABS_MT_POSITION_Y), value 661 > Event: time 1725264307.131523, type 3 (EV_ABS), code 48 (ABS_MT_TOUCH_MAJOR), value 12 > Event: time 1725264307.131523, type 3 (EV_ABS), code 0 (ABS_X), value 859 > Event: time 1725264307.131523, type 3 (EV_ABS), code 1 (ABS_Y), value 661 > Event: time 1725264307.131523, -------------- SYN_REPORT ------------ > Event: time 1725264307.150540, type 3 (EV_ABS), code 53 (ABS_MT_POSITION_X), value 795 > Event: time 1725264307.150540, type 3 (EV_ABS), code 54 (ABS_MT_POSITION_Y), value 671 > Event: time 1725264307.150540, type 3 (EV_ABS), code 48 (ABS_MT_TOUCH_MAJOR), value 13 > Event: time 1725264307.150540, type 3 (EV_ABS), code 0 (ABS_X), value 795 > Event: time 1725264307.150540, type 3 (EV_ABS), code 1 (ABS_Y), value 671 > Event: time 1725264307.150540, -------------- SYN_REPORT ------------ > Event: time 1725264307.169589, type 3 (EV_ABS), code 53 (ABS_MT_POSITION_X), value 760 > Event: time 1725264307.169589, type 3 (EV_ABS), code 54 (ABS_MT_POSITION_Y), value 675 > Event: time 1725264307.169589, type 3 (EV_ABS), code 0 (ABS_X), value 760 > Event: time 1725264307.169589, type 3 (EV_ABS), code 1 (ABS_Y), value 675 > Event: time 1725264307.169589, -------------- SYN_REPORT ------------ > Event: time 1725264307.188157, type 3 (EV_ABS), code 57 (ABS_MT_TRACKING_ID), value -1 > Event: time 1725264307.188157, type 1 (EV_KEY), code 330 (BTN_TOUCH), value 0 > Event: time 1725264307.188157, -------------- SYN_REPORT ------------ > > So, > > Tested-by: Andreas Kemnade <andreas@xxxxxxxxxxxx> # Tolino Shine2HD Thank you for giving it a spin! -- Dmitry