On Tue, Aug 20, 2024 at 12:37:03PM -0400, Frank Li wrote: > Convert binding doc ads7846.txt to yaml format. > Additional change: > - add ref to touchscreen.yaml and spi-peripheral-props.yaml. > - use common node name touchscreen. > - sort ti properties alphabetically. > - sort common properties alphabetically. > - sort compatible string alphabetically. > - remove vcc-supply from required list. > - deprecated ti,x-min, ti,y,min ti,y-min? > > Fix below warning: arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dtb: touchscreen@0: > ti,x-min: b'\x00}' is not of type 'object', 'array', 'boolean', 'null' > > Reviewed-by: Marek Vasut <marex@xxxxxxx> > Signed-off-by: Frank Li <Frank.Li@xxxxxxx> > --- > Change from v4 to v5 > - Add Reviewed-by: Marek Vasut <marex@xxxxxxx> > - Start sentence with uppercase letter > > Change from v3 to v4 > - new line for all descrptions > - add . after sentense. > > Change from v2 to v3 > - Remove u16(u32) in descriptions > - deprecated ti,x-min and ti, y-min > > Change from v1 to v2 > - sort properties, by 3 group: > 1. General (compatible, reg, interrupt) > 2. Common properties > 3. ti properties > - sort maintainers name alphabetically. > - uint16 have to be kept because default is uint32 > - remove vcc-supply from required list > - remove unfinished sentence "all mandatory properties described in" > because it refer to /schemas/spi/spi-peripheral-props.yaml# > - fix make refcheckdoc error > --- > .../bindings/input/touchscreen/ads7846.txt | 107 ---------- > .../input/touchscreen/ti,ads7843.yaml | 182 ++++++++++++++++++ > .../bindings/power/wakeup-source.txt | 2 +- > 3 files changed, 183 insertions(+), 108 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/input/touchscreen/ads7846.txt > create mode 100644 Documentation/devicetree/bindings/input/touchscreen/ti,ads7843.yaml > diff --git a/Documentation/devicetree/bindings/input/touchscreen/ti,ads7843.yaml b/Documentation/devicetree/bindings/input/touchscreen/ti,ads7843.yaml > new file mode 100644 > index 0000000000000..92d5e7d3b1ffd > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/touchscreen/ti,ads7843.yaml > @@ -0,0 +1,182 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/input/touchscreen/ti,ads7843.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: TI's SPI driven touch screen controllers. Drop period. > + > +maintainers: > + - Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx> > + - Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> > + - Marek Vasut <marex@xxxxxxx> > + > +description: > + Device tree bindings for TI's ADS7843, ADS7845, ADS7846, ADS7873, TSC2046 Drop 'Device tree bindings for '. > + SPI driven touch screen controllers. > + > +properties: > + compatible: > + enum: > + - ti,ads7843 > + - ti,ads7845 > + - ti,ads7846 > + - ti,ads7873 > + - ti,tsc2046 > + > + interrupts: > + maxItems: 1 > + > + pendown-gpio: > + description: > + GPIO handle describing the pin the !PENIRQ line is connected to. maxItems: 1 > + > + vcc-supply: > + description: > + A regulator node for the supply voltage. > + > + wakeup-source: true > + > + ti,debounce-max: > + deprecated: true > + $ref: /schemas/types.yaml#/definitions/uint16 > + description: > + Max number of additional readings per sample. > + > + ti,debounce-rep: > + $ref: /schemas/types.yaml#/definitions/uint16 > + description: > + Additional consecutive good readings required after the first two. > + > + ti,debounce-tol: > + $ref: /schemas/types.yaml#/definitions/uint16 > + description: > + Tolerance used for filtering. > + > + ti,hsync-gpios: > + description: > + GPIO line to poll for hsync. maxItems: 1 With those fixes, Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx>