…
> +++ b/drivers/hid/hid-corsair-void.c
> @@ -0,0 +1,842 @@
…
> +enum {
> + CORSAIR_VOID_BATTERY_NORMAL = 1,
…
> + CORSAIR_VOID_BATTERY_CHARGING = 5,
> +};
Would you like to choose a corresponding name for such an enumeration?
Can any other data type be reused for this purpose?
…
> +static ssize_t send_alert_store(struct device *dev,
> + struct device_attribute *attr,
> + const char *buf, size_t count)
> +{
…
> + if (ret < 0) {
> + hid_warn(hid_dev, "failed to send alert request (reason: %d)",
> + ret);
> + } else {
> + ret = count;
> + }
Would you like to omit curly brackets here?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.11-rc4#n197
Regards,
Markus
