> Such information should not belong to the change description. > It may be specified behind the marker line. > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.11-rc3#n711 I was just beginning to think I actually had the format right, thanks for the link > Will any enumeration values become more helpful here? Yes that's clearer, done locally, it'll be in the v2 > Please improve the size determination (or explanation). That should be 2 bytes, thanks. It doesn't really need to be kzalloc() then if the whole thing is set, the same goes for the other calls to kzalloc(). I'll change those to kmalloc() unless there's a reason not to. > I guess that you would not like to preserve code which was commented out. I did mean to leave that there for the v1 only to ask if it was worthwhile leaving, but I forgot to ask about it. There's a comment ~16 lines back saying to use that exit point for any failures after that point. It was a reminder while things were moving around a lot, but I can drop it now if it's not worth keeping. Thanks for the review Stuart
