Re: [PATCH] Input: increase max button number to 0x3ff

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Jul 05 2024, Michał Kopeć wrote:
> Do you have any guess as to where this old value came from?
> It's weird that this wasn't caught already.
> 
> CCing some more maintainers to get some more eyes on this, I hope that's okay.
> 

Dmitry will probably know better but I've made the forensic, and that
value came from 03bac96fae0e ("Input: expand keycode space").
The value seemed arbitrary, but we do try to keep it low because there
are a lot of static arrays in the kernel which are using KEY_MAX as a
size.

Also, it might be worth double checking, but last time we tried
something similar on EV_ABS range and it fell short because of the ioctl
that couldn't work properly IIRC. I don't seem to find the ML
discussion, but it would be interesting for someone to un-earth it and
see if we are facing similar issues.

Cheers,
Benjamin




[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux