Hi Krzysztof, > -----Original Message----- > From: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > Sent: Thursday, July 4, 2024 11:59 AM > To: Agarwal, Utsav <Utsav.Agarwal@xxxxxxxxxx>; Hennerich, Michael > <Michael.Hennerich@xxxxxxxxxx>; Dmitry Torokhov > <dmitry.torokhov@xxxxxxxxx>; Rob Herring <robh@xxxxxxxxxx>; Krzysztof > Kozlowski <krzk+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>; Sa, > Nuno <Nuno.Sa@xxxxxxxxxx> > Cc: linux-input@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; Artamonovs, Arturs > <Arturs.Artamonovs@xxxxxxxxxx>; Bimpikas, Vasileios > <Vasileios.Bimpikas@xxxxxxxxxx>; Gaskell, Oliver > <Oliver.Gaskell@xxxxxxxxxx> > Subject: Re: [PATCH v6 3/3] dt-bindings: input: Update dtbinding for adp5588 > > [External] > > On 04/07/2024 12:45, Utsav Agarwal via B4 Relay wrote: > > + > > + - | > > + #include <dt-bindings/interrupt-controller/irq.h> > > + #include <dt-bindings/input/input.h> > > + #include <dt-bindings/gpio/gpio.h> > > + > > + i2c { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + gpio@34 { > > + compatible = "adi,adp5588"; > > + reg = <0x34>; > > + > > + #gpio-cells = <2>; > > + gpio-controller; > > + }; > > Fix your indentation. It's total mess above. > > Best regards, > Krzysztof Apologies for the same, I will be fixing it. Thanks, Utsav