Hi Rob, > -----Original Message----- > From: Rob Herring (Arm) <robh@xxxxxxxxxx> > Sent: Monday, July 1, 2024 5:28 PM > To: Agarwal, Utsav <Utsav.Agarwal@xxxxxxxxxx> > Cc: Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; > Hennerich, Michael <Michael.Hennerich@xxxxxxxxxx>; > devicetree@xxxxxxxxxxxxxxx; Artamonovs, Arturs > <Arturs.Artamonovs@xxxxxxxxxx>; Sa, Nuno <Nuno.Sa@xxxxxxxxxx>; > Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>; Bimpikas, Vasileios > <Vasileios.Bimpikas@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>; > Gaskell, Oliver <Oliver.Gaskell@xxxxxxxxxx>; linux-input@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v4 2/2] dt-bindings: input: Update dtbinding for adp5588 > > [External] > > > On Mon, 01 Jul 2024 16:04:51 +0100, Utsav Agarwal wrote: > > Updating dt bindings for adp5588. Following properties are now made > > optional: > > - interrupts > > - keypad,num-rows > > - keypad,num-columns > > - linux,keymap > > The proposed new property "gpio-only" has been added as an optional > > property with an additional example. > > > > Signed-off-by: Utsav Agarwal <utsav.agarwal@xxxxxxxxxx> > > --- > > .../devicetree/bindings/input/adi,adp5588.yaml | 28 > ++++++++++++++++++---- > > 1 file changed, 24 insertions(+), 4 deletions(-) > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review- > ci/linux/Documentation/devicetree/bindings/input/adi,adp5588.yaml: gpio- > only: missing type definition Thank you for the feedback, I will fix this and confirm with dt_binding_check before resubmitting the next version. > > doc reference errors (make refcheckdocs): > > See > https://urldefense.com/v3/__https://patchwork.ozlabs.org/project/devicetr > ee-bindings/patch/20240701-adp5588_gpio_support-v4-2- > 44bba0445e90@analog.com__;!!A3Ni8CS0y2Y!6DaQ5a3iw3kzzWwCpDz9K5X > ABnIHXNsXMTyaGAc53YJ1gYBgSwKyiPMSl620Xo2okCIQ1P1ftU0rJkD5$ > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your > schema.
