On Thu, 6 Jun 2024, at 9:53 PM, Hans de Goede wrote: > Hi Benjamin, > > On 6/6/24 10:49 AM, Benjamin Tissoires wrote: > > On May 29 2024, Hans de Goede wrote: > >> Hi all, > >> > >> On 5/29/24 3:28 AM, Luke D. Jones wrote: > >>> Changelog: > >>> - v1 > >>> - Split the patch in two > >>> - Move function body to asus-wmi and export > >>> - Use array of names and for loops > >>> > >>> History: > >>> - https://lore.kernel.org/linux-input/20240528013959.14661-1-luke@xxxxxxxxxx/T/#u > >>> > >>> Luke D. Jones (2): > >>> hid-asus: use hid for brightness control on keyboard > >>> hid-asus: change the report_id used for HID LED control > >>> > >>> drivers/hid/hid-asus.c | 32 +++++++++++++++++++- > >>> drivers/platform/x86/asus-wmi.c | 35 +++++++++++++++++++++- > >>> include/linux/platform_data/x86/asus-wmi.h | 10 +++++++ > >>> 3 files changed, 75 insertions(+), 2 deletions(-) > >> > >> Jiri, Benjamin since the first patch now also touches pdx86 files > >> we need to coordinate merging this. > >> > >> There also is a long list of patches pending for > >> drivers/platform/x86/asus-wmi.c > >> > >> So I would prefer to take this series (both patches) upstream through > >> the pdx86 tree to avoid conflicts. > >> > >> May we have an ack from one of you for merging this through pdx86/for-next ? > > > > Sure: > > Acked-by: Benjamin Tissoires <bentiss@xxxxxxxxxx> > > Thank you for the ack. > > > But I haven't seen the v2. Are you sure you want to take this series as > > it is? > > No I plan to wait for v2, I just thought it would be good to have > an ack to merge this through the pdx86 tree beforehand. My apologies for the delay, I have v2 prepped, but I'm waiting on feedback from a few folks regarding the 2024 G16 and G14, plus the TUF laptops - these are possibly affected by the patch. Shouldn't be more than a day or two now. Regards, Luke.