On Thu, 2024-06-06 at 08:28 +0200, Krzysztof Kozlowski wrote: > PLEXUS SECURITY WARNING > You have not previously corresponded with this sender. > On 06/06/2024 01:12, Danny Kaehn wrote: > > This is a USB HID device which includes an I2C controller and 8 > GPIO pins. > > > > The binding allows describing the chip's gpio and i2c controller in > DT > > using the subnodes named "gpio" and "i2c", respectively. This is > > intended to be used in configurations where the CP2112 is > permanently > > connected in hardware. > > > > Signed-off-by: Danny Kaehn <danny.kaehn@xxxxxxxxxx> > > --- > > .../devicetree/bindings/i2c/silabs,cp2112.yaml | 105 > +++++++++++++++++++++ > > 1 file changed, 105 insertions(+) > > So this is v11 but was never tested? My apologies -- initially `DT_SCHEMA_FILES=silabs,cp2112.yaml make dt_binding_check` was completing without any output (and I assumed success), but after a clean, I get make errors, either relating to "no rule to make ... *.example.dtb", or yamllint usage errors. Have tried updating dtschema and/or reinstalling, and also started from scratch on a different system with the same issues. I will get this working and run this before submitting additional revisions, apologies again! (and I will of course fix the issue reported by the bot) > > Changelog does not help me understanding what happened with this > binding... I'll keep in mind better specifying changes to the binding in the changelog! Since v6, where Rob added his review tag [1], the only changes were eliminating the gpio subnode and combining it with the parent, and updating my email address. Since v4, where you had added your review tag [2], I addressed Rob's comments in [3], including: - Removing the ngpios property - Constraining the hog pattern more to a single naming scheme - Removing unneeded properties from the hog which are provided by the parent schema - Adding an example of the hog to test the schema Additionally, I added sda-gpios and scl-gpios to the i2c node as well as usage of it in the example dts. This is intended to be used for bus recovery GPIOs (not yet included in the kernel drivers) [1]: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230217184904.1290-2-kaehndan@xxxxxxxxx/ [2]: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230206135016.6737-2-kaehndan@xxxxxxxxx/ [3]: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230205145450.3396-2-kaehndan@xxxxxxxxx/#3051932 Thanks, Danny Kaehn > Best regards, > Krzysztof >
