* XBox -> Xbox (lowercase 'b') as per official Microsoft branding * the controller itself has more than one paddle, hence rephrasing "exports the paddle" to reflext this * rephrase the description of "those" usage to explicitly make reference to the paddles which lends itself to replace the SDL statement to them * report -> reports grammatical fix in favor of present tense verb. Reports is refering to the act the action being performed by the subject, in this case the kernel * spelling fix: interpret * capitalized first word in bullet points for consistency Signed-off-by: Luis Felipe Hernandez <luis.hernandez093@xxxxxxxxx> --- .../hid/bpf/progs/Microsoft__XBox-Elite-2.bpf.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/hid/bpf/progs/Microsoft__XBox-Elite-2.bpf.c b/drivers/hid/bpf/progs/Microsoft__XBox-Elite-2.bpf.c index c04abecab8ee..858cf20ebe2c 100644 --- a/drivers/hid/bpf/progs/Microsoft__XBox-Elite-2.bpf.c +++ b/drivers/hid/bpf/progs/Microsoft__XBox-Elite-2.bpf.c @@ -15,20 +15,19 @@ HID_BPF_CONFIG( ); /* - * When using the XBox Wireless Controller Elite 2 over Bluetooth, - * the device exports the paddle on the back of the device as a single + * When using the Xbox Wireless Controller Elite 2 over Bluetooth, + * the device exports the paddles on the back of the device as a single * bitfield value of usage "Assign Selection". * - * The kernel doesn't process those usages properly and report KEY_UNKNOWN - * for it. + * The kernel doesn't process the paddles usage properly and reports KEY_UNKNOWN. * - * SDL doesn't know how to interprete that KEY_UNKNOWN and thus ignores the paddles. + * SDL doesn't know how to interpret KEY_UNKNOWN and thus ignores them. * * Given that over USB the kernel uses BTN_TRIGGER_HAPPY[5-8], we - * can tweak the report descriptor to make the kernel interprete it properly: - * - we need an application collection of gamepad (so we have to close the current + * can tweak the report descriptor to make the kernel interpret it properly: + * - We need an application collection of gamepad (so we have to close the current * Consumer Control one) - * - we need to change the usage to be buttons from 0x15 to 0x18 + * - We need to change the usage to be buttons from 0x15 to 0x18 */ #define OFFSET_ASSIGN_SELECTION 211 -- 2.45.1
