On Fri, May 03, 2024 at 08:29:15PM +0200, Christoph Fritz wrote: > Hello Conor, > > thanks for having an eye on this, please see my answer below. > > On Fri, 2024-05-03 at 18:12 +0100, Conor Dooley wrote: > > On Thu, May 02, 2024 at 08:27:59PM +0200, Christoph Fritz wrote: > > > Add dt-bindings for serial LIN bus adapters. These adapters are > > > basically just LIN transceivers that are hard-wired to serial devices. > > > > > > Signed-off-by: Christoph Fritz <christoph.fritz@xxxxxxxxx> > > > --- > > > .../bindings/net/can/hexdev,lin-serdev.yaml | 32 +++++++++++++++++++ > > > 1 file changed, 32 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/net/can/hexdev,lin-serdev.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/net/can/hexdev,lin-serdev.yaml b/Documentation/devicetree/bindings/net/can/hexdev,lin-serdev.yaml > > > new file mode 100644 > > > index 0000000000000..c178eb9be1391 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/net/can/hexdev,lin-serdev.yaml > > > @@ -0,0 +1,32 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/net/can/hexdev,lin-serdev.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Serial LIN Adapter > > > + > > > +description: > > > + LIN transceiver, mostly hard-wired to a serial device, used for communication > > > + on a LIN bus. > > > + For more details on an adapter, visit <https://hexdev.de/hexlin#tty>. > > > + > > > +maintainers: > > > + - Christoph Fritz <christoph.fritz@xxxxxxxxx> > > > + > > > +properties: > > > + compatible: > > > + const: hexdev,lin-serdev > > > > Maybe I've just missed something on earlier versions that I didn't > > read, but the name of the device on the website you link is "hexLIN", > > so why is "lin-serdev" used here instead? > > The USB one is called hexLIN and has it's own HID driver. > > This serial LIN adapter doesn't really have a product name. Currently > on our website it's generically called 'UART LIN Adapter'. > > This LIN adapter is basically just a LIN transceiver and very generic, > so that one could solder it to any single-board computer with an uart. > > I think 'lin-serdev' for LIN and serial device fits great, also serdev > is the name of the used kernel infrastructure (besides the LIN glue > driver). > > If you still don't like it, I'm open to other names. What about > "hexlin-uart" or "linser"? I dunno, I don't really care about it being called "hexlin,lin-serdev", all that much, I just found it confusing that the link in the description sent me to the ""Hello World" in LIN" section of your site. If it had dropped me off at the "UART LIN adapter" section things woud've been less confusing. That said, calling the compatible after a linux-ism is a bit odd to me when the device seems to be called a "UART LIN adapter" on the page, not a "serdev". Cheers, Conor.
Attachment:
signature.asc
Description: PGP signature
