On Wed, Apr 24, 2024 at 04:14:06PM -0700, Alexey Makhalov wrote: > VCPU_RESERVED and LEGACY_X2APIC are not VMware hypercall commands. > These are bits in return value of VMWARE_CMD_GETVCPU_INFO command. > Change VMWARE_CMD_ prefix to GETVCPU_INFO_ one. And move bit-shift > operation to the macro body. I don't understand: $ git grep GETVCPU_INFO arch/x86/kernel/cpu/vmware.c:51:#define VMWARE_CMD_GETVCPU_INFO 68 arch/x86/kernel/cpu/vmware.c:478: VMWARE_CMD(GETVCPU_INFO, eax, ebx, ecx, edx); so that's a VMWARE_CMD 68, at least the prefix says so. And those two are *bits* in that eax which that hypercall returns. Or are those two bits generic but defined in a vmware-specific hypercall? Hm. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette