On Tue, 23 Apr 2024 14:18:23 +0200 Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: Hi, > On 23/04/2024 12:15, Andre Przywara wrote: > > On Mon, 22 Apr 2024 17:45:10 +0100 > > Andre Przywara <andre.przywara@xxxxxxx> wrote: > > > > Hi, > > > >> From: James McGregor <jamcgregor@xxxxxxxxxxxxxx> > >> > >> The Allwinner H616 SoC has an LRADC which is compatible with the > >> versions in existing SoCs. > >> Add a compatible string for H616, with the R329 fallback. This is the > >> same as the D1, so put them into an enum. > >> > >> Signed-off-by: James McGregor <jamcgregor@xxxxxxxxxxxxxx> > >> Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx> > > > > Compared the descriptions in the manual between the R392 and the H616, they > > look the same: > > > > Reviewed-by: Andre Przywara <andre.przywara@xxxxxxx> > > Why do you review your own patches? Does it mean that you contribute > code which you did not review before? I just merely sent the code on behalf of James, because he had trouble with the email setup (Protonmail has no SMTP), but didn't want to delay the post any longer. > This is odd process. I agree, I would have liked it more if James would have sent it himself, and then my review would look more natural, but with my review I wanted to explicitly point out the technical correctness. Besides: I found this ordering issue in the other patch only after sending, so needed to somehow respond anyway. Also I wanted to make the process transparent: someone posts a patch (in this case via a proxy), then it gets reviewed. > Your Review is implied by sending the patch. Is that really true? I was under the impression that sending is independent from review. I mean I doubt that every maintainer sending patches up the chain (when they add their SoB) implies a *review*? Surely they do agree on the patch (also typically expressed by an Ack), otherwise they wouldn't send it, but a "review" is still a different thing. The Linux history has both Rb + SoB from the same person and just SoB signatures, so I assume that it's not implied. > And you have there SoB which indicates you sent it... Yes, but SoB just means I sign off on the legal aspects: that I got the patches legally, compliant with the GPL, and that I am fine with and allowed to release them under GPL conditions. That does not include any code review aspect, AFAICT. Happy to hear other opinions, but this is my interpretation. Cheers, Andre
