Jiri Kosina <jikos@xxxxxxxxxx> 於 2024年4月3日 週三 下午7:48寫道： > > On Tue, 2 Apr 2024, Allen_Lin wrote: > > > Hi, > > This driver implements for Himax HID touchscreen HX83102j. > > > > Using SPI interface to receive/send HID packets. > > > > Changes in v2 : > > -Added power description in YAML document. > > -Added ddreset-gpios property in YAML document. > > -Added firmware-name property in YAML document. > > -Modified the description of pid. > > -Modified the example. > > > > Allen_Lin (4): > > dt-bindings: input: Add Himax HX83102J touchscreen > > HID: Add Himax HX83102J touchscreen driver > > HID: Add DRM panel follower function > > HID: Load firmware directly from file to IC > > > > .../input/touchscreen/himax,hx83102j.yaml | 100 + > > MAINTAINERS | 7 + > > drivers/hid/Kconfig | 7 + > > drivers/hid/Makefile | 2 + > > drivers/hid/hid-himax-83102j.c | 3071 +++++++++++++++++ > > drivers/hid/hid-himax-83102j.h | 460 +++ > > My only nit here -- could we please call the driver just hid-himax, to > follow the pattern we generally use in this subsystem (drivers named after > vendors). > 83102j is our IC name, we add it to our driver name to distinguish different ICs, Can we just reserve this in driver name? Thanks Allen > Please add Ack from Rob, rename the driver, resend, and I'll apply it. > Thanks, > > -- > Jiri Kosina > SUSE Labs >
