Thanks Hans
On Mon, Apr 8, 2024, at 9:11 AM, Hans de Goede wrote:
> Hi,
>
> On 3/24/24 10:08 PM, Mark Pearson wrote:
>> New Lenovo platforms are adding the FN+N key to generate system debug
>> details that support can use for collecting important details on any
>> customer cases for Windows.
>> Add the infrastructure so we can do the same on Linux by generating a
>> SYS_DEBUG_INFO keycode to userspace.
>>
>> Signed-off-by: Mark Pearson <mpearson-lenovo@xxxxxxxxx>
>> Signed-off-by: Nitin Joshi <njoshi1@xxxxxxxxxx>
>> ---
>> drivers/platform/x86/thinkpad_acpi.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
>> index 2bbb32c898e9..854ce971bde2 100644
>> --- a/drivers/platform/x86/thinkpad_acpi.c
>> +++ b/drivers/platform/x86/thinkpad_acpi.c
>> @@ -1787,6 +1787,7 @@ enum { /* hot key scan codes (derived from ACPI DSDT) */
>> TP_ACPI_HOTKEYSCAN_NOTIFICATION_CENTER,
>> TP_ACPI_HOTKEYSCAN_PICKUP_PHONE,
>> TP_ACPI_HOTKEYSCAN_HANGUP_PHONE,
>> + TP_ACPI_HOTKEYSCAN_SYS_DEBUG_INFO = 81,
>>
>> /* Hotkey keymap size */
>> TPACPI_HOTKEY_MAP_LEN
>> @@ -3337,6 +3338,9 @@ static int __init hotkey_init(struct ibm_init_struct *iibm)
>> KEY_NOTIFICATION_CENTER, /* Notification Center */
>> KEY_PICKUP_PHONE, /* Answer incoming call */
>> KEY_HANGUP_PHONE, /* Decline incoming call */
>> + KEY_UNKNOWN, /* AMT Toggle (event), 0x31A */
>> + KEY_UNKNOWN, KEY_UNKNOWN,
>> + KEY_SYS_DEBUG_INFO, /* System debug info, 0x31D */
>> },
>> };
>>
>
> Looking at the next patch 0x131c is TP_HKEY_EV_DOUBLETAP_TOGGLE and 0x131a is
> TP_HKEY_EV_AMT_TOGGLE based on this please change this to:
>
> KEY_NOTIFICATION_CENTER, /* Notification Center */
> KEY_PICKUP_PHONE, /* Answer incoming call */
> KEY_HANGUP_PHONE, /* Decline incoming call */
> KEY_UNKNOWN, /* TP_HKEY_EV_AMT_TOGGLE handled in driver, 0x31a */
> KEY_UNKNOWN, /* ?, 0X31b */
> KEY_UNKNOWN, /* TP_HKEY_EV_DOUBLETAP_TOGGLE handled in driver, 0x31c */
> KEY_SYS_DEBUG_INFO, /* System debug info, 0x31d */
> },
>
Will do
Mark
