Should I resubmit a v2 with that tag? Or is it not necessary?
Sorry for the clumsiness, it's my first patch.
Nuno Pereira
From: Jiri Kosina <jikos@xxxxxxxxxx>
Sent: Friday, March 22, 2024 11:02
To: Nuno Pereira <nf.pereira@xxxxxxxxxx>
Cc: linux-input@xxxxxxxxxxxxxxx <linux-input@xxxxxxxxxxxxxxx>; Daniel Ogorchock <djogorchock@xxxxxxxxx>; Ryan McClelland <rymcclel@xxxxxxxxx>; benjamin.tissoires@xxxxxxxxxx <benjamin.tissoires@xxxxxxxxxx>
Subject: Re: [PATCH] HID: nintendo: Fix N64 controller being identified as mouse
On Mon, 26 Feb 2024, Nuno Pereira wrote:
> This patch is regarding the recent addition of support for the NSO
> controllers to hid-nintendo. All controllers are working correctly with the
> exception of the N64 controller, which is being identified as a mouse by
> udev. This results in the joystick controlling the mouse cursor and the
> controller not being detected by games.
>
> The reason for this is because the N64's C buttons have been attributed to
> BTN_FORWARD, BTN_BACK, BTN_LEFT, BTN_RIGHT, which are buttons typically
> attributed to mice.
>
> This patch changes those buttons to controller buttons, making the
> controller be correctly identified as such.
>
> Signed-off-by: Nuno Pereira <nf.pereira@xxxxxxxxxx>
Thanks for the fix. I believe it's missing
Fixes: 94f18bb1994591 ("HID: nintendo: add support for nso controllers")
tag.
Ryan, what was the reason for your initial assignment to FWD/BCK/LFT/RGHT
instad of SELECT/X/Y/C ?
Thanks,
--
Jiri Kosina
SUSE Labs
