On Tue, 5 Mar 2024, srinivas pandruvada wrote:
> > The variable dev->devc in ish_dev_init was utilized by dev_err before
> > it was properly assigned. To rectify this, the assignment of dev->devc
> > has been moved to immediately follow memory allocation.
> >
> > Without this change "(NULL device *)" is printed for device
> > information.
> >
> > Fixes: 8ae2f2b0a284 ("HID: intel-ish-hid: ipc: Fix potential use-
> > after-free in work function")
> > Fixes: ae02e5d40d5f ("HID: intel-ish-hid: ipc layer")
> > Signed-off-by: Zhang Lixu <lixu.zhang@xxxxxxxxx>
> > Acked-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
> > ---
> This is not an important change to submit to rc cycle.
> This is just a logging issue.
Agreed about the severity. However it fixes a user-visible issue and
doesn't have a potential to cause any regression, so I have just queued it
in hid.git#for-6.9/upstream-fixes nevertheless.
Thanks,
--
Jiri Kosina
SUSE Labs
