Hi Jeff,
Thank you for the kind remarks and thorough review.
All of your points, here and across the series, you can consider
acknowledged and I will work to adopt them in the next version.
There were a few loose ends and questions throughout the series which I
intend to address over the coming days. The first one is below.
>> +
>> +static const struct reg_sequence cs40l50_irq_mask_override[] = {
>> + { CS40L50_IRQ1_MASK_2, CS40L50_IRQ_MASK_2_OVERRIDE },
>> + { CS40L50_IRQ1_MASK_20, CS40L50_IRQ_MASK_20_OVERRIDE },
>> +};
>> +
>> +static int cs40l50_configure_dsp(struct cs_dsp *dsp)
>> +{
>> + struct cs40l50 *cs40l50 = container_of(dsp, struct cs40l50, dsp);
>> + u32 nwaves;
>> + int err;
>> +
>> + /* Log number of effects if wavetable was loaded */
>> + if (cs40l50->bin) {
>
> Is there any other clue you can use to discern whether a wavetable was
> loaded? The memory at cs40l50->bin is gone now, and although you're not
> dereferencing it anymore, another contributor might be fooled into doing
> so down the road.
>
> Maybe a boolean would be more maintainable; I don't feel strongly about
> it though.
I will simply remove the conditional. If no wavetable was loaded, the
register will have a value of 0, which is no less worthwhile to report to the
user.
Best,
James
