On Tue, Mar 05, 2024 at 07:01:02PM +0200, Andy Shevchenko wrote: > On Tue, Mar 5, 2024 at 12:10 PM Uwe Kleine-König > <u.kleine-koenig@xxxxxxxxxxxxxx> wrote: > > ... > > > there are a few other exit paths that could use dev_err_probe(), but IIRC > > Dmitry isn't a fan of using dev_err_probe() where the return value cannot be > > EPROBE_DEFER, so I'm only changing this one error path. > > It's not true anymore. He is fine with that API, and please use it. I would not get ahead of ourselves ;) I still think we could have done this better by: 1. Having a format option for printing symbolic errors 2. Recording deferral source at supplier level But yes, I am accepting patches and new drivers using dev_err_probe(). Thanks. -- Dmitry