Re: [v2] Input: iqs269a - Use scope-based resource management in iqs269_parse_chan()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> The extra curly braces are absolutely not needed. The for loop's body
> already defines scope, __cleanup()s should be called at the end of the body.

I present an other development opinion here.
I got the impression that the required scope should be smaller for
the adjusted local variable “ev_node” (according to the previous function implementation).

Otherwise:
How do you think about to move any source code part from the loop
into a separate function?

Regards,
Markus





[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux