On Fri, 23 Feb 2024, Takashi Iwai wrote: > On Fri, 23 Feb 2024 16:45:59 +0100, > Lee Jones wrote: > > > > On Tue, 13 Feb 2024, Heiner Kallweit wrote: > > > > > If a simple trigger is assigned to a LED, then the LED may be off until > > > the next led_trigger_event() call. This may be an issue for simple > > > triggers with rare led_trigger_event() calls, e.g. power supply > > > charging indicators (drivers/power/supply/power_supply_leds.c). > > > Therefore persist the brightness value of the last led_trigger_event() > > > call and use this value if the trigger is assigned to a LED. > > > This change allows to use simple triggers in more cases. > > > As a first use case simplify handling of the mute audio trigger. > > > > > > This series touches few subsystems. I'd propose to handle it via > > > the LED subsystem. > > > > > > Heiner Kallweit (4): > > > leds: trigger: Store brightness set by led_trigger_event() > > > ALSA: control-led: Integrate mute led trigger > > > Input: leds: Prepare for removal of config option LEDS_AUDIO_TRIGGER > > > leds: trigger: audio: Remove this trigger > > > > > > arch/mips/configs/ci20_defconfig | 1 - > > > drivers/input/input-leds.c | 8 +--- > > > drivers/leds/led-triggers.c | 6 ++- > > > drivers/leds/trigger/Kconfig | 7 --- > > > drivers/leds/trigger/Makefile | 1 - > > > drivers/leds/trigger/ledtrig-audio.c | 67 ---------------------------- > > > include/linux/leds.h | 29 ++++++------ > > > sound/core/Kconfig | 1 - > > > sound/core/control_led.c | 20 +++++++-- > > > 9 files changed, 37 insertions(+), 103 deletions(-) > > > delete mode 100644 drivers/leds/trigger/ledtrig-audio.c > > > > Are the sound maintainers on-board with this? > > See > https://lore.kernel.org/r/87zfw1ewrd.wl-tiwai@xxxxxxx Were you happy with Heiner's response? -- Lee Jones [李琼斯]
