Thomas Zimmermann <tzimmermann@xxxxxxx> writes: > The driver sets struct fb_info.bl_dev to the correct backlight > device. Thus rely on the backlight core code to match backlight > and framebuffer devices, and remove the extra check_fb function > from struct backlight_ops. > > Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx> > Cc: "Bruno Prémont" <bonbons@xxxxxxxxxxxxxxxxx> > --- [...] > +#ifdef CONFIG_HID_PICOLCD_BACKLIGHT > + info->bl_dev = data->backlight; > +#endif > + The robot complains about this, I think that you also need to guard against CONFIG_FB_BACKLIGHT being defined. Alternatively, you could include a preparatory patch to fix the HID_PICOLCD_BACKLIGHT config symbol dependencies. Other than that, Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx> -- Best regards, Javier Martinez Canillas Core Platforms Red Hat
